RFR 6563286 6797318 8177648 - Undeclared IAE thrown from HttpURLConnection.connect for some URLs

[Jaikiran Pai]

Hello Michael,

On 31/07/19 11:43 AM, Michael McMahon wrote:
> ...
>>>
>>> I wonder if another solution is possible where the IAE is caught
>>> at the appropriate place(s) and converted to an IOException
>>> which is what users are expecting.
>> I can update the proposed patch to redo it to catch the IAE and throw
>> the IOException at the relevant places. Would you also want me to update
>> any javadoc of the ProxySelector to make it more clear of this (so far)
>> implicit behaviour? Does that require a CSR?
>
> I think it would be good to do that, and it would require a CSR.
> The existing @throws statement could be expanded to make this explicit
> perhaps.

I have now redone the patch to allow the DefaultProxySelector to
continue to throw the IAE for missing host/protocol in the URI and then
let it be caught in the relevant places and throw a IOException. I have
also updated the javadoc of ProxySelector to explicitly state this
previously implicit behaviour. The 2 new testcases have been updated to
test these changes appropriately.

The new webrev is at
http://cr.openjdk.java.net/~jpai/webrev/defaultproxyselector/2/webrev/.

Apart from the review and sponsoring I will also need help on creating a
CSR for this one.

-Jaikiran