RFR(XS): 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6

[Nick Gasson]

Hi,

Thanks Alan and Daniel for the suggestions. I've made these changes here:

http://cr.openjdk.java.net/~ngasson/8229912/webrev.1/

Nick


On 21/08/2019 17:05, Daniel Fuchs wrote:
> Hi Nick,
> 
> Thanks for finding this issue and proposing a fix.
> I agree with Alan that throwing SkipException would be a better
> choice, we have started using that more frequently recently.
> 
> In addition jdk.test.lib.NetworkConfiguration [1] provides a
> static printSystemConfiguration method that could be used to
> print the interface configurations before throwing the
> exception (you would have to add `* @library /test/lib` to
> the test headers to be able to use it).
> 
> best regards,
> 
> -- daniel
> 
> [1]
> http://hg.openjdk.java.net/jdk/jdk/file/tip/test/lib/jdk/test/lib/NetworkConfiguration.java#l383
> 
> On 21/08/2019 07:55, Nick Gasson wrote:
>> Hi,
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8229912
>> Webrev: http://cr.openjdk.java.net/~ngasson/8229912/webrev.0/
>>
>> This test should be skipped if IPv6 is disabled on the host, and it
>> already has a shouldRun field to support this. But at the moment the
>> the setUp() method will throw inside HttpServer.create() when it's
>> passed an IPv6 address on a system with IPv6 disabled. Fix is to check
>> shouldRun in setUp and return immediately if it's false.
>>
>> Thanks,
>> Nick
>