RFR(XS): 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6

[Alan Bateman]

On 21/08/2019 11:45, Nick Gasson wrote:
> On 21/08/2019 18:30, Alan Bateman wrote:
>>
>> Daniel - if there are other changes to this test then it might be worth
>> re-examining the ensureXXX methods. The naming is very strange as they
>> return a boolean. Also they print messages to say that the test is
>> skipped but it's the caller that will determinate that, not the
>> ensureXXX methods.
>>
>
> We could make those two methods return void and throw the 
> SkipException themselves? I don't mind doing that change in this patch.
I don't want to expand the scope of your changes, it was just a passing 
comment. I think returning boolean is fine, I just think the method 
names are misleading and they should not be printing anything. It's up 
to the caller of these methods to decide whether to skip.

-Alan