RFR: 8230310: SocksSocketImpl should handle the IllegalArgumentException thrown by ProxySelector.select usage

Daniel Fuchs daniel.fuchs at oracle.com
Thu Aug 29 09:26:34 UTC 2019


Thanks for the test Jaikiran!

Since an IOException is expected at line 76, I believe
it would be good for the test to trow an assertion error
if that doesn't happen.

Maybe simply insert:
    throw new AssertionError("expected exception not thrown");
between lines 75 and 76?

best regards,

-- daniel

On 29/08/2019 08:04, Jaikiran Pai wrote:
> Hello Daniel,
> 
> Here's an updated webrev which includes a test case to verify this
> change http://cr.openjdk.java.net/~jpai/webrev/8230310/2/webrev/
> 
> -Jaikiran


More information about the net-dev mailing list