RFR: 8230310: SocksSocketImpl should handle the IllegalArgumentException thrown by ProxySelector.select usage

Jaikiran Pai jai.forums2013 at gmail.com
Thu Aug 29 09:48:33 UTC 2019


Hello Daniel,

On 29/08/19 2:56 PM, Daniel Fuchs wrote:
> Thanks for the test Jaikiran!
>
> Since an IOException is expected at line 76, I believe
> it would be good for the test to trow an assertion error
> if that doesn't happen.
>
> Maybe simply insert:
>    throw new AssertionError("expected exception not thrown");
> between lines 75 and 76?

You are right of course, I missed that. I have now updated the test and
the webrev is at the same location
http://cr.openjdk.java.net/~jpai/webrev/8230310/2/webrev/

-Jaikiran




More information about the net-dev mailing list