RFR: 8230310: SocksSocketImpl should handle the IllegalArgumentException thrown by ProxySelector.select usage

[Daniel Fuchs]

Thanks! Looks fine. I see you have used Assert.fail and that's
better than what I suggested.

I can be your sponsor if you want. Count me as Reviewer!

best regards,

-- daniel

On 29/08/2019 10:48, Jaikiran Pai wrote:
>> Maybe simply insert:
>>     throw new AssertionError("expected exception not thrown");
>> between lines 75 and 76?
> You are right of course, I missed that. I have now updated the test and
> the webrev is at the same location
> http://cr.openjdk.java.net/~jpai/webrev/8230310/2/webrev/
> 
> -Jaikiran
> 
>