RFR: 8216986 Remove unused code from SocksSocketImpl

[Michael McMahon]

On 23/01/2019, 12:37, Alan Bateman wrote:
> On 23/01/2019 11:44, Michael McMahon wrote:
>> Hi
>>
>> Could I get the following webrev reviewed please?
>> It is just to remove dead code from SocksSocketImpl.
>> Most of the code was an (unused) attempt to implement
>> SOCKS for ServerSockets. getLocalPort() was potentially buggy
>> and should not override the super class implementation.
>> So, that was removed too. A couple of other orphaned methods
>> are removed also.
>>
>> http://cr.openjdk.java.net/~michaelm/8216986/webrev.1/
> This is a good cleanup. Seems wrong for getLocalPort to return the 
> "remote" address of the SOCKS server so that fix looks correct. Does 
> it need a test?
>

I can add a test for that.

> At some point I think we need to get this SocketImpl changed so that 
> it delegates rather than extends PlainSocketImpl. I suspect that work 
> will identify a few other oddities with SOCKS connections that may not 
> be obvious now.
>

Yes, that's what I plan to do next.

Thanks,

Michael.