RFR: 8216986 Remove unused code from SocksSocketImpl

[Michael McMahon]

I've updated the webrev at 
http://cr.openjdk.java.net/~michaelm/8216986/webrev.2/
to add some tests and also I found the same dubious implementation of 
getLocalPort()
in HttpConnectSocketImpl.java. The test infrastructure needed some 
cleanup also.

Thanks,

Michael.

On 23/01/2019, 14:30, Michael McMahon wrote:
>
>
> On 23/01/2019, 12:37, Alan Bateman wrote:
>> On 23/01/2019 11:44, Michael McMahon wrote:
>>> Hi
>>>
>>> Could I get the following webrev reviewed please?
>>> It is just to remove dead code from SocksSocketImpl.
>>> Most of the code was an (unused) attempt to implement
>>> SOCKS for ServerSockets. getLocalPort() was potentially buggy
>>> and should not override the super class implementation.
>>> So, that was removed too. A couple of other orphaned methods
>>> are removed also.
>>>
>>> http://cr.openjdk.java.net/~michaelm/8216986/webrev.1/
>> This is a good cleanup. Seems wrong for getLocalPort to return the 
>> "remote" address of the SOCKS server so that fix looks correct. Does 
>> it need a test?
>>
>
> I can add a test for that.
>
>> At some point I think we need to get this SocketImpl changed so that 
>> it delegates rather than extends PlainSocketImpl. I suspect that work 
>> will identify a few other oddities with SOCKS connections that may 
>> not be obvious now.
>>
>
> Yes, that's what I plan to do next.
>
> Thanks,
>
> Michael.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20190124/25e17e6d/attachment.html>