RFR [14] 8226303: Test convenience reactive primitives from java.net.http with RS TCK

Chris Hegarty chris.hegarty at oracle.com
Tue Jun 25 13:16:36 UTC 2019


Pavel,

> On 24 Jun 2019, at 13:31, Pavel Rappo <pavel.rappo at oracle.com> wrote:
> 
> Hello,
> 
> Please review the following change:
> 
>    http://cr.openjdk.java.net/~prappo/8226602/webrev.00/

Thanks for doing this Pavel, the changes look great.

> This change adds reactive streams conformance testing of convenience primitives
> exposed by java.net.http.HttpClient. The TckDriver.java file from the webrev
> provides some explanation on the general structure of the test suite.

Clearly there are some limitations by the desire to compile the
RS-TCK classes just a single time, but I think where you have
ended up with this is quite good.

> The reactive streams TCK was obtained by flattening four modules (api, examples,
> tck and tck-flow) from commit 77a7e573e431cbc567630988a01473e42504e5c5 (May 27
> 2019) on the https://github.com/reactive-streams/reactive-streams-jvm repo into
> a single source tree under test/jdk/java/net/httpclient/reactivestreams-tck.

Seems reasonable.

-Chris.



More information about the net-dev mailing list