RFR [14] 8226303: Test convenience reactive primitives from java.net.http with RS TCK

[Daniel Fuchs]

Hi Pavel,

This looks very good! Thanks for driving this effort.

Would it be possible to add a one-line comment at the beginning
of each test to explain what they are testing?

For instance, I see in BodyPublishersFromPublisher.java:

   32 /* See TckDriver.java for more information */
   33 public class BodyPublishersFromPublisher
   34         extends FlowPublisherVerification<ByteBuffer> {

It is not immediately obvious that is a test for:

java.net.http.HttpRequest.BodyPublishers::fromPublisher

this could have been made clearer with the following comment:

   30 /* Tests the conformance of the publisher returned by
   31  * java.net.http.HttpRequest.BodyPublishers::fromPublisher
   32  * See TckDriver.java for more information */

best regards,

-- daniel


On 24/06/2019 13:31, Pavel Rappo wrote:
> Hello,
> 
> Please review the following change:
> 
>      http://cr.openjdk.java.net/~prappo/8226602/webrev.00/
> 
> This change adds reactive streams conformance testing of convenience primitives
> exposed by java.net.http.HttpClient. The TckDriver.java file from the webrev
> provides some explanation on the general structure of the test suite.
> 
> The reactive streams TCK was obtained by flattening four modules (api, examples,
> tck and tck-flow) from commit 77a7e573e431cbc567630988a01473e42504e5c5 (May 27
> 2019) on the https://github.com/reactive-streams/reactive-streams-jvm repo into
> a single source tree under test/jdk/java/net/httpclient/reactivestreams-tck.
> 
> Thanks,
> -Pavel
>