RFR[8233989]: Create an IPv4 version of java/net/MulticastSocket/SetLoopbackMode.java

Daniel Fuchs daniel.fuchs at oracle.com
Wed Nov 13 11:28:38 UTC 2019


Thanks for taking care of that Patrick!

The call to IPSupport.throwSkippedExceptionIfNonOperational();
should ensure that the new test will be skipped if IPv4 is not
available on the machine, so that looks good to me!

best regards,

-- daniel

On 13/11/2019 11:18, Patrick Concannon wrote:
> Hi,
> 
> 
> Could someone please review my fix for issue JDK-8233989 'Create an IPv4 
> version of java/net/MulticastSocket/SetLoopbackMode.java' ?
> 
> This fix circumvents the issue by adding a new SetLoopbackModeIPv4 test 
> that calls SetLoopbackMode in IPv4 only mode, and runs only if IPv4 is 
> enabled.
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8233989
> webrev: http://cr.openjdk.java.net/~pconcannon/8233989/webrevs/webrev.00/
> 
> 
> 
> Kind regards,
> 
> Patrick
> 



More information about the net-dev mailing list