RFR[8233860]: java/net/SocketOption/AfterClose.java test incorrectly handles IP_MULTICAST_IF

Patrick Concannon patrick.concannon at oracle.com
Wed Nov 13 16:12:55 UTC 2019


Hi,


Could someone please review my fix for issue JDK-8233860 
'java/net/SocketOption/AfterClose.java test incorrectly handles 
IP_MULTICAST_IF' ?

The test, AfterClose.java, makes a call to setOption() after a socket 
has been closed to verify that a SocketException is thrown correctly. 
However, the test uses an invalid value (boolean) for the 
IP_MULTICAST_IF option invalidating the test.
This fix corrects this error, and passes valid input for the 
IP_MULTICAST_IF option (i.e. a NetworkInterface) ensuring that the test 
behaves as expected.

bug: https://bugs.openjdk.java.net/browse/JDK-8233860
webrev: 
http://cr.openjdk.java.net/~pconcannon/8233860/webrevs/webrev.00/ 
<http://cr.openjdk.java.net/~pconcannon/8233989/webrevs/webrev.00/>



Kind regards,

Patrick

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20191113/d0978166/attachment.html>


More information about the net-dev mailing list