RFR[8243488]: 'Add tests for set/get SendBufferSize and getReceiveBufferSize in DatagramSocket'

[Patrick Concannon]

Hi Alan,

Yeah, sounds good. I’ve added that test case as requested, and you can 
find it in the updated webrev below.

http://cr.openjdk.java.net/~pconcannon/8243488/webrevs/webrev.01/

Kind regards,

Patrick


On 24/04/2020 09:59, Alan Bateman wrote:
> On 23/04/2020 16:46, Patrick Concannon wrote:
>> Hi,
>>
>> Could someone please review my fix for JDK-8243488 'Add tests for 
>> set/get SendBufferSize and getReceiveBufferSize in DatagramSocket'?
>>
>> This fix adds tests for the methods: setSendBufferSize(int), 
>> getSendBufferSize(), and getReceieveBufferSize() in the 
>> DatagramSocket class, and is geared towards increasing the overall 
>> test coverage for this class.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8243488
>> webrev: 
>> http://cr.openjdk.java.net/~pconcannon/8243488/webrevs/webrev.00/
> Another potential test for SetGetSendBufferSize is a 
> testInitialSendBufferSize to check that the initial value of SO_SNDBUF 
> is >= 65507 when Platform.isOSX() is true. That test could be refined 
> further when JDK-8242885 is fixed.
>
> -Alan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20200424/5df1fdc4/attachment.htm>