RFR[8243488]: 'Add tests for set/get SendBufferSize and getReceiveBufferSize in DatagramSocket'
Alan Bateman
Alan.Bateman at oracle.com
Sat Apr 25 14:53:45 UTC 2020
On 24/04/2020 21:00, Patrick Concannon wrote:
>
> Hi Alan,
>
> Yeah, sounds good. I’ve added that test case as requested, and you can
> find it in the updated webrev below.
>
> http://cr.openjdk.java.net/~pconcannon/8243488/webrevs/webrev.01/
>
testInitialSendBufferSize looks good, thanks for adding that.
A minor nit is that the @AfterTest method is in the middle of several
tests so not easy to check that it cleans up exactly the resources that
the @BeforeTest method creates. It might be helpful to move it so that
it is declared after Setup. No new webrev needed for that of course.
-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20200425/48ec6e84/attachment.htm>
More information about the net-dev
mailing list