RFR(s): Improving performance of Windows socket connect on the loopback adapter
Alan Bateman
Alan.Bateman at oracle.com
Tue Jul 21 15:18:36 UTC 2020
On 21/07/2020 02:34, Nikola Grcevski wrote:
> Hi Alan and Bernd,
>
> Thanks again for the code review of my changes and the suggestions!
>
> Please find the updated webrev here:
>
> http://cr.openjdk.java.net/~adityam/nikola/fast_connect_loopback_2/
>
> I decided to explicitly check so_rv for success consistently in the two places. It feels safer
> against future changes to the internal implementation of getsockopt.
>
> I left the JNICALL and jint to match the other similar functions in the net
> helper functions file as before. It sounds like future clean-up will simplify this, but if I
> misunderstood from your comments please let me know and I'll update accordingly.
>
I think this version looks okay, except that I'd prefer if the if the
expression at L244-246 were on one line, not split over there. Do you
have a sponsor to push this?
-Alan
More information about the net-dev
mailing list