RFR(s): Improving performance of Windows socket connect on the loopback adapter

[Nikola Grcevski]

Thanks again Alan. My apologies for the delayed response, I was away most of yesterday.

I've updated the webrev with the change as requested:

http://cr.openjdk.java.net/~adityam/nikola/fast_connect_loopback_3/

None of us here at Microsoft have contributor status yet, so I'll need a sponsor to get this change merged.

Best,
Nikola

-----Original Message-----
From: Alan Bateman <Alan.Bateman at oracle.com> 
Sent: July 21, 2020 11:19 AM
To: Nikola Grcevski <Nikola.Grcevski at microsoft.com>; net-dev at openjdk.java.net
Subject: Re: RFR(s): Improving performance of Windows socket connect on the loopback adapter



On 21/07/2020 02:34, Nikola Grcevski wrote:
> Hi Alan and Bernd,
>
> Thanks again for the code review of my changes and the suggestions!
>
> Please find the updated webrev here:
>
> https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.open
> jdk.java.net%2F~adityam%2Fnikola%2Ffast_connect_loopback_2%2F&data
> =02%7C01%7CNikola.Grcevski%40microsoft.com%7C4d89c178d8a147bc6e1708d82
> d895c25%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63730941526294228
> 9&sdata=75i%2BHx1QXiqydrPd49Z4UbiO83SSLCxgXBrzovGDs%2FY%3D&res
> erved=0
>
> I decided to explicitly check so_rv for success consistently in the 
> two places. It feels safer against future changes to the internal implementation of getsockopt.
>
> I left the JNICALL and jint to match the other similar functions in 
> the net helper functions file as before. It sounds like future 
> clean-up will simplify this, but if I misunderstood from your comments please let me know and I'll update accordingly.
>
I think this version looks okay, except that I'd prefer if the if the expression at L244-246 were on one line, not split over there. Do you have a sponsor to push this?

-Alan