RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly

[Vyom Tiwari]

Hi Daniel/Alan,
Please find the latest webrev(
http://cr.openjdk.java.net/~vtewari/8237858/webrev0.6/index.html).
Thanks,
Vyom

On Wed, Jun 24, 2020 at 5:32 PM Vyom Tiwari <vyommani at gmail.com> wrote:

> let me refactor the test, i will try to incorporate your suggestion.
> Vyom
>
>
> On Wed, Jun 24, 2020 at 5:21 PM Daniel Fuchs <daniel.fuchs at oracle.com>
> wrote:
>
>> On 24/06/2020 12:14, Vyom Tiwari wrote:
>> > 3-> Looking at SocketAcceptInterruptTest it looks like the test
>> > will succeed if it manages to send the signal - and that's it.
>> > Is it really a measure of success?
>> > No, I explained in  question 2.
>> >
>>
>> So basically you rely on the test infrastructure having
>> registered an UncaughtExceptionHandler to catch the exception
>> thrown by your server thread.
>>
>> I would prederably not rely on this, and instead check whether
>> the exception has been thrown by the server thread from
>> the main thread.
>>
>> best regards,
>>
>> -- daniel
>>
>
>
> --
> Thanks,
> Vyom
>


-- 
Thanks,
Vyom
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20200626/ae2fed5b/attachment-0001.htm>