RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly

Alan Bateman Alan.Bateman at oracle.com
Sat Jun 27 06:16:09 UTC 2020


On 26/06/2020 05:17, Vyom Tiwari wrote:
> Hi Daniel/Alan,
> Please find the latest 
> webrev(http://cr.openjdk.java.net/~vtewari/8237858/webrev0.6/index.html).
>
I think we can do better than one signal after 200ms. Have you given any 
thought to have a thread that signals many times so that you have a 
better chance of tickling bugs?  One other comment at this time is that 
the value of SIGPIPE is still hardcoded - I think you'll need to add 
another native method to return its value.

BTW:  The formatting issues with linux_close.c and bsd_close.c are the 
same as the previous iterations. Did you track down that issue, I think 
you thought it was webrev or an issue with your patch queue.

-Alan.



More information about the net-dev mailing list