RFR: 8244958: preferIPv4Stack and preferIPv6Addresses do not affect addresses returned by HostsFileNameService
Daniel Fuchs
daniel.fuchs at oracle.com
Tue May 26 11:39:28 UTC 2020
Hi Aleksei,
Still looks good to me.
One detail that jumped at me however:
1079 if (res.size() == 0) {
should probably be changed to `if (res.isEmpty()) {`
No need for a new webrev.
best regards,
-- daniel
On 26/05/2020 11:22, Aleks Efimov wrote:
> Hi Alan,
>
> Thank you for the review. I've renamed 'appendAddresses' to
> 'concatAddresses' per your suggestion.
> And also removed 'arrangeAddresses' method and moved its code to
> 'lookupAllHostAddr'.
>
> Webrev with new version can be viewed here:
> http://cr.openjdk.java.net/~aefimov/8244958/02
>
> -Aleksei
More information about the net-dev
mailing list