RFR: 8244958: preferIPv4Stack and preferIPv6Addresses do not affect addresses returned by HostsFileNameService

Aleks Efimov aleksej.efimov at oracle.com
Tue May 26 11:56:21 UTC 2020


Thank you, Daniel! Changed it to 'isEmpty'.

-Aleksei

On 26/05/2020 12:39, Daniel Fuchs wrote:
> Hi Aleksei,
>
> Still looks good to me.
> One detail that jumped at me however:
>
> 1079             if (res.size() == 0) {
>
> should probably be changed to `if (res.isEmpty()) {`
>
> No need for a new webrev.
>
> best regards,
>
> -- daniel
>
> On 26/05/2020 11:22, Aleks Efimov wrote:
>> Hi Alan,
>>
>> Thank you for the review. I've renamed 'appendAddresses' to 
>> 'concatAddresses' per your suggestion.
>> And also removed  'arrangeAddresses' method and moved its code to 
>> 'lookupAllHostAddr'.
>>
>> Webrev with new version can be viewed here:
>> http://cr.openjdk.java.net/~aefimov/8244958/02
>>
>> -Aleksei



More information about the net-dev mailing list