RFR: 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders` [v7]

Patrick Concannon pconcannon at openjdk.java.net
Thu Nov 5 17:08:10 UTC 2020


> Hi,
> 
> Could someone please review my fix for JDK-8253005: 'Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
> 
> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is unspecified in its javadoc. This fix adds an `@throws IOException` to its specification and a description of the conditions under which the exception is thrown.
> 
> Kind regards,
> Patrick

Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision:

  8252304: Added read to TestHandler to ensure requestBody consumed before closing exchange

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1014/files
  - new: https://git.openjdk.java.net/jdk/pull/1014/files/f7363f7e..814a7fd0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1014&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1014&range=05-06

  Stats: 14 lines in 1 file changed: 2 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1014.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1014/head:pull/1014

PR: https://git.openjdk.java.net/jdk/pull/1014


More information about the net-dev mailing list