RFR: 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders` [v6]

Patrick Concannon pconcannon at openjdk.java.net
Thu Nov 5 16:56:14 UTC 2020


> Hi,
> 
> Could someone please review my fix for JDK-8253005: 'Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
> 
> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is unspecified in its javadoc. This fix adds an `@throws IOException` to its specification and a description of the conditions under which the exception is thrown.
> 
> Kind regards,
> Patrick

Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:

 - Merge remote-tracking branch 'origin/master' into JDK-8253005
 - 8253005: Added test to verify `IOException` thrown when headers already sent
 - Merge remote-tracking branch 'origin/master' into JDK-8253005
 - Merge remote-tracking branch 'origin/master' into JDK-8253005
 - Merge remote-tracking branch 'origin/master' into JDK-8253005
 - Merge remote-tracking branch 'origin/master' into JDK-8253005
 - Merge remote-tracking branch 'origin/master' into JDK-8253005
 - Merge remote-tracking branch 'origin/master' into JDK-8253005
 - 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders`

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1014/files
  - new: https://git.openjdk.java.net/jdk/pull/1014/files/0c5c7744..f7363f7e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1014&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1014&range=04-05

  Stats: 1770 lines in 166 files changed: 744 ins; 780 del; 246 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1014.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1014/head:pull/1014

PR: https://git.openjdk.java.net/jdk/pull/1014


More information about the net-dev mailing list