RFR: 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders` [v5]

[Patrick Concannon]

On Thu, 5 Nov 2020 10:52:19 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - 8253005: Added test to verify `IOException` thrown when headers already sent
>>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>>  - 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders`
>
> test/jdk/java/net/httpclient/SendResponseHeadersTest.java line 86:
> 
>> 84:     static class TestHandler implements HttpHandler {
>> 85:         public void handle(HttpExchange exchange) throws IOException {
>> 86:             exchange.sendResponseHeaders(200, 0);
> 
> It's always preferable to read the request body fully before calling `sendResponseHeaders`

Thanks for pointing this out. I've added it to the test, and you can view it in commit https://github.com/openjdk/jdk/pull/1014/commits/814a7fd014d7706f63ed239f8be56ff26190b1f5

-------------

PR: https://git.openjdk.java.net/jdk/pull/1014