RFR: 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders` [v10]
Patrick Concannon
pconcannon at openjdk.java.net
Fri Nov 6 16:47:17 UTC 2020
> Hi,
>
> Could someone please review my fix for JDK-8253005: 'Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>
> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is unspecified in its javadoc. This fix adds an `@throws IOException` to its specification and a description of the conditions under which the exception is thrown.
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
- Merge remote-tracking branch 'origin/master' into JDK-8253005
- 8253005: Added URIBuilder to test
- 8253005: Restructured test to use @BeforeTest/@AfterTest
- Merge remote-tracking branch 'origin/master' into JDK-8253005
- 8252304: Added read to TestHandler to ensure requestBody consumed before closing exchange
- Merge remote-tracking branch 'origin/master' into JDK-8253005
- 8253005: Added test to verify `IOException` thrown when headers already sent
- Merge remote-tracking branch 'origin/master' into JDK-8253005
- Merge remote-tracking branch 'origin/master' into JDK-8253005
- Merge remote-tracking branch 'origin/master' into JDK-8253005
- ... and 4 more: https://git.openjdk.java.net/jdk/compare/156e6f71...a908c612
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1014/files
- new: https://git.openjdk.java.net/jdk/pull/1014/files/8ff6d9b4..a908c612
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1014&range=09
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1014&range=08-09
Stats: 481 lines in 7 files changed: 425 ins; 25 del; 31 mod
Patch: https://git.openjdk.java.net/jdk/pull/1014.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1014/head:pull/1014
PR: https://git.openjdk.java.net/jdk/pull/1014
More information about the net-dev
mailing list