RFR: 8253005: Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders` [v10]

Daniel Fuchs dfuchs at openjdk.java.net
Fri Nov 6 17:36:01 UTC 2020


On Fri, 6 Nov 2020 16:47:17 GMT, Patrick Concannon <pconcannon at openjdk.org> wrote:

>> Hi,
>> 
>> Could someone please review my fix for JDK-8253005: 'Add `@throws IOException` in javadoc for `HttpEchange.sendResponseHeaders`' ?
>> 
>> The method `HttpEchange.sendResponseHeaders` throws an `IOException` but is unspecified in its javadoc. This fix adds an `@throws IOException` to its specification and a description of the conditions under which the exception is thrown.
>> 
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>  - 8253005: Added URIBuilder to test
>  - 8253005: Restructured test to use @BeforeTest/@AfterTest
>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>  - 8252304: Added read to TestHandler to ensure requestBody consumed before closing exchange
>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>  - 8253005: Added test to verify `IOException` thrown when headers already sent
>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>  - Merge remote-tracking branch 'origin/master' into JDK-8253005
>  - ... and 4 more: https://git.openjdk.java.net/jdk/compare/eb3d3f21...a908c612

Marked as reviewed by dfuchs (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1014


More information about the net-dev mailing list