RFR: 8252374: Add a new factory method to concatenate a sequence of BodyPublisher instances into a single publisher. [v11]
Daniel Fuchs
dfuchs at openjdk.java.net
Wed Oct 7 13:12:33 UTC 2020
> Continuing the review with a PR...
>
> 8252374: Add a new factory method to concatenate a sequence
> of BodyPublisher instances into a single publisher.
> https://bugs.openjdk.java.net/browse/JDK-8252374
>
>
> Draft CSR:
> https://bugs.openjdk.java.net/browse/JDK-8252382
Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since
the last revision:
- Merge
- Added a plain test for positive requests.
- Keep changes to PullPublisher for a later fix
- Fixed handling of negative request. Added BodyPublishers::concat to the TCK tests.
- Use a dataProvider for testNegativeRequest
- Merge
- Added a test case for requesting a non positive number of items.
- Merge
- Incorporated review comments
- Improved the API documentation of BodyPublishers::concat
- ... and 5 more: https://git.openjdk.java.net/jdk/compare/702cde1a...9ff5a3b3
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/57/files
- new: https://git.openjdk.java.net/jdk/pull/57/files/9719bf29..9ff5a3b3
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=57&range=10
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=57&range=09-10
Stats: 4647 lines in 169 files changed: 2498 ins; 1156 del; 993 mod
Patch: https://git.openjdk.java.net/jdk/pull/57.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/57/head:pull/57
PR: https://git.openjdk.java.net/jdk/pull/57
More information about the net-dev
mailing list