RFR: 8252374: Add a new factory method to concatenate a sequence of BodyPublisher instances into a single publisher. [v11]

Chris Hegarty chegar at openjdk.java.net
Fri Oct 9 08:18:11 UTC 2020


On Wed, 7 Oct 2020 13:12:33 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Continuing the review with a PR...
>> 
>> 8252374: Add a new factory method to concatenate a sequence
>>          of BodyPublisher instances into a single publisher.
>> https://bugs.openjdk.java.net/browse/JDK-8252374
>> 
>> 
>> Draft CSR:
>> https://bugs.openjdk.java.net/browse/JDK-8252382
>
> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
> excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since
> the last revision:
>  - Merge
>  - Added a plain test for positive requests.
>  - Keep changes to PullPublisher for a later fix
>  - Fixed handling of negative request. Added BodyPublishers::concat to the TCK tests.
>  - Use a dataProvider for testNegativeRequest
>  - Merge
>  - Added a test case for requesting a non positive number of items.
>  - Merge
>  - Incorporated review comments
>  - Improved the API documentation of BodyPublishers::concat
>  - ... and 5 more: https://git.openjdk.java.net/jdk/compare/2210e3d2...9ff5a3b3

Marked as reviewed by chegar (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/57


More information about the net-dev mailing list