RFR: 8252767: URLConnection.setRequestProperty throws IllegalAccessError [v4]

[Robin Westberg]

On Mon, 7 Sep 2020 09:37:23 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> Slightly OT - but I think this `/integrate` command shouldn't actually be in the hands of the contributor and instead
>> should be decided and issued by "committers" or "sponsors". I don't really see how the contributor/author can
>> realistically decide when it's the right time to intiate a `/integrate`
>
> @jaikiran No need to be sorry, you are following the process as it is outlined. Please go ahead with the suggestion to
> update the test to use TestNG. The current state of the PR should not affect updates. BTW AFAIK, you should not need to
> "force push" - just push to the branch.

@jaikiran For what it's worth, this is how the interaction was designed. When an author that isn't an OpenJDK Committer
issues the `/integrate` command, it merely signals that *you* think the change is ready. If a reviewer disagrees, they
will let you know, and you can continue to work on the pull request. Any new commit pushed to your branch will cause
the "sponsor" label to be removed.

If the author didn't have to issue the `/integrate` command we would have the opposite problem - your sponsor can't
know that you think that your contribution is really ready - perhaps you have another minor cleanup lined up and are
just about to push it. But perhaps we can make this clearer in the message from the bot.

-------------

PR: https://git.openjdk.java.net/jdk/pull/26