RFR: 8260366: ExtendedSocketOptions <clinit> can deadlock in some circumstances [v2]

[Jaikiran Pai]

On Wed, 17 Feb 2021 13:11:23 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Incorporate the review suggestion to run the test multiple times to improve the chances of reproducing any potential deadlock
>>  - Incorporate the review suggestion to use @modules instead of --add-exports option while launching the test
>>  - Fix copyright message on test
>
> Hi Jaikiran, 
> 
> Thanks for taking a go at this one.
> 
> At a glance - the proposed fix seems reasonable to me. It would be good to have another pair of eyes (and analysis) on this though. Some issues with the test.

Hello Daniel, thank you for the review. I have updated this PR to incorporate your review suggestions for the test.

> test/jdk/sun/net/ext/ExtendedSocketOptionsTest.java line 10:
> 
>> 8:  * particular file as subject to the "Classpath" exception as provided
>> 9:  * by Oracle in the LICENSE file that accompanied this code.
>> 10:  *
> 
> Tests do not need - nor should they have - the "Classpath" exception - please see Copyright notice of other tests in the vicinity.

Thank you for catching this. I've fixed it in the latest update of the PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2601