RFR: 8260366: ExtendedSocketOptions <clinit> can deadlock in some circumstances [v2]
Vyom Mani Tewari
github.com+4410404+vyommani at openjdk.java.net
Wed Feb 17 16:50:39 UTC 2021
On Wed, 17 Feb 2021 13:36:18 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Hi Jaikiran,
>>
>> Thanks for taking a go at this one.
>>
>> At a glance - the proposed fix seems reasonable to me. It would be good to have another pair of eyes (and analysis) on this though. Some issues with the test.
>
> Hello Daniel, thank you for the review. I have updated this PR to incorporate your review suggestions for the test.
Changes looks OK to me, any specific reason for removing "final" specifier from "getInstance" & "register" methods ?.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2601
More information about the net-dev
mailing list