RFR: 8260366: ExtendedSocketOptions <clinit> can deadlock in some circumstances [v2]
Jaikiran Pai
jpai at openjdk.java.net
Thu Feb 18 01:11:38 UTC 2021
On Wed, 17 Feb 2021 16:47:51 GMT, Vyom Mani Tewari <github.com+4410404+vyommani at openjdk.org> wrote:
> Changes looks OK to me, any specific reason for removing "final" specifier from "getInstance" & "register" methods ?.
Hello Vyom, thank you for the review. Since those two methods are `static`, the `final` was redundant on them and since this patch was already changing those 2 methods, I decided to remove it while I was at it. However, if you and others feel that this patch shouldn't change it, I will introduce it back.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2601
More information about the net-dev
mailing list