RFR: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value

[Daniel Fuchs]

On Fri, 5 Aug 2022 09:04:19 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> test/jdk/sun/net/www/http/KeepAliveCache/B8291637.java line 27:
>> 
>>> 25:  * @test
>>> 26:  * @bug 8291637
>>> 27:  * @run main/othervm -Dhttp.keepAlive.time.server=20 -esa -ea B8291637
>> 
>> Is it intentional that we are setting the -esa and -ea options here?
>
> If we enable assertions without the bug fix, then an assertion is triggered in KeepAliveCache, which is useful.

tests are usually run with `-esa -ea` in our test systems, but individual developers could "forget" to specify those options. So in the case where it's the only thing that would make the test fail without the fix (or in the case where it would provide additional diagnostic for the particular bug fix) it can make sense to add them in the `@run` too...

-------------

PR: https://git.openjdk.org/jdk/pull/9755