RFR: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value [v2]

Michael McMahon michaelm at openjdk.org
Fri Aug 5 10:32:56 UTC 2022


> Hi,
> 
> Some new keep alive tests are exposing some old bugs. In this case if the server sends an invalid timeout (say -20 seconds) we accept it creating a timeout in the past. So, the first time the keep alive thread wakes up it will close the connection.
> The correct behavior is to ignore the invalid parameter and fallback to the default timeout or the timeout set by the relevant system property.
> 
> Thanks,
> Michael

Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:

  update from Jai's review

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9755/files
  - new: https://git.openjdk.org/jdk/pull/9755/files/fc083025..5d028bdb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9755&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9755&range=00-01

  Stats: 23 lines in 2 files changed: 12 ins; 1 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/9755.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9755/head:pull/9755

PR: https://git.openjdk.org/jdk/pull/9755


More information about the net-dev mailing list