RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v2]

Conor Cleary ccleary at openjdk.java.net
Mon Mar 14 11:29:46 UTC 2022


On Mon, 7 Mar 2022 12:17:53 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Conor Cleary has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8263031: Tidied up import statements
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java line 803:
> 
>> 801:             if (pcs != null) {
>> 802:                 if (frame instanceof ContinuationFrame cf) {
>> 803:                     handlePushContinuation(stream, cf);
> 
> IOException should probably be caught and transformed in protocol error here to?
> In case of protocol error when handling push promise (or their continuation) - should `pcs` be reset to null?
> Maybe it doesn't matter since we're closing the connection anyway.

In my opinion it would probably be safest to set pcs to null here yes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7696


More information about the net-dev mailing list