RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v2]

Daniel Fuchs dfuchs at openjdk.java.net
Tue Mar 15 14:33:46 UTC 2022


On Tue, 15 Mar 2022 11:26:55 GMT, Conor Cleary <ccleary at openjdk.org> wrote:

>> Good idea yes, to check that the repeat continuation still behaves as expected. Should hopefully be straight forward to create another test case.
>
> On this issue, there is a case where a faulty server might send an indefinite number of Continuations (maybe the server never sets an END_HEADERS flag). Should a safe guard for the Push Promise with Continuation/s case be put in place to prevent the faulty scenario?

It would be impossible to detect, but if the server is faulty and "forget" to set the END_HEADERS flag, then we will detect that because the next frame we receive won't be the ContinuationFrame we expect.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7696


More information about the net-dev mailing list