RFR: 8263031: HttpClient throws Exception if it receives a Push Promise that is too large [v2]

[Conor Cleary]

On Mon, 14 Mar 2022 11:19:36 GMT, Conor Cleary <ccleary at openjdk.org> wrote:

>> test/jdk/java/net/httpclient/http2/PushPromiseContinuation.java line 176:
>> 
>>> 174:             ContinuationFrame cf = new ContinuationFrame(streamid, HeaderFrame.END_HEADERS, encodedHeaders);
>>> 175: 
>>> 176:             try {
>> 
>> It would be good to have a test-case that creates 2 continuation frames too.
>
> Good idea yes, to check that the repeat continuation still behaves as expected. Should hopefully be straight forward to create another test case.

On this issue, there is a case where a faulty server might send an indefinite number of Continuations (maybe the server never sets an END_HEADERS flag). Should a safe guard for the Push Promise with Continuation/s case be put in place to prevent the faulty scenario?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7696