RFR: 8296804: Document HttpClient configuration properties in java.net.http module-info [v7]

Jaikiran Pai jpai at openjdk.org
Fri Nov 25 07:27:37 UTC 2022


On Thu, 24 Nov 2022 11:18:33 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Hi,
>> 
>> Could I get the following doc change reviewed please? It documents the system/networking properties used by the java.net.http HTTP client in its module-info. (CSR to follow)
>> 
>> Thanks,
>> Michael
>
> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update to be compatible with JDK-8297030

src/java.net.http/share/classes/module-info.java line 136:

> 134:  * <li><p><b>{@systemProperty jdk.internal.httpclient.disableHostnameVerification}</b> (default: false)<br>
> 135:  * If true, hostname verification in SSL certificates is disabled. This is a system property only and not
> 136:  * available in {@code conf/net.properties}. It is provided for testing purposes only.

>From what I can see in the code `jdk.internal.net.http.common.Utils#hostnameVerificationDisabledValue()`, we consider an empty value for this property to imply `true`. Perhaps we should note that here?

-------------

PR: https://git.openjdk.org/jdk/pull/11241


More information about the net-dev mailing list