RFR: 8296804: Document HttpClient configuration properties in java.net.http module-info [v7]

[Michael McMahon]

On Fri, 25 Nov 2022 07:20:26 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update to be compatible with JDK-8297030
>
> src/java.net.http/share/classes/module-info.java line 59:
> 
>> 57:  * <li><p><b>{@systemProperty jdk.httpclient.connectionWindowSize}</b> (default: 2^26)<br>
>> 58:  * The HTTP/2 client connection window size in bytes. The maximum size is 2^31-1. This value cannot be
>> 59:  * smaller than the stream window size.
> 
> Should this additionally point to the `jdk.httpclient.windowsize` system property? Something like `This value cannot be smaller than the stream window size, which can be configured through {@code jdk.httpclient.windowsize} system property`?

Good idea!

> src/java.net.http/share/classes/module-info.java line 84:
> 
>> 82:  *   <li>ssl</li>
>> 83:  *   <li>trace</li>
>> 84:  *   <li>channel</li>
> 
> Hello Michael, is it intentional that we haven't documented `content` in this list?

Thanks for noticing that omission Jai!

> src/java.net.http/share/classes/module-info.java line 136:
> 
>> 134:  * <li><p><b>{@systemProperty jdk.internal.httpclient.disableHostnameVerification}</b> (default: false)<br>
>> 135:  * If true, hostname verification in SSL certificates is disabled. This is a system property only and not
>> 136:  * available in {@code conf/net.properties}. It is provided for testing purposes only.
> 
> From what I can see in the code `jdk.internal.net.http.common.Utils#hostnameVerificationDisabledValue()`, we consider an empty value for this property to imply `true`. Perhaps we should note that here?

Yes, agreed!

-------------

PR: https://git.openjdk.org/jdk/pull/11241