RFR: 8294958: java/net/httpclient/ConnectTimeout tests are slow

Daniel Fuchs dfuchs at openjdk.org
Mon Oct 10 11:04:51 UTC 2022


On Fri, 7 Oct 2022 11:53:25 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Please review this test-only change that improves the execution times of ConnectTimeout tests:
> - ConnectTimeoutHandshakeAsync and ConnectTimeoutHandshakeSync: before this change each one takes 80+ seconds to execute.
> - ConnectTimeoutNoProxyAsync, ConnectTimeoutNoProxySync, ConnectTimeoutWithProxyAsync, ConnectTimeoutWithProxySync: before this change each one takes 50+ seconds to execute.
> 
> After this change each test completes successfully under 10 seconds.

LGTM. Reducing the number of values produced by the data providers seems like a good strategy.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10605


More information about the net-dev mailing list