RFR: 8294958: java/net/httpclient/ConnectTimeout tests are slow

Aleksei Efimov aefimov at openjdk.org
Mon Oct 10 11:15:55 UTC 2022


On Fri, 7 Oct 2022 11:53:25 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Please review this test-only change that improves the execution times of ConnectTimeout tests:
> - ConnectTimeoutHandshakeAsync and ConnectTimeoutHandshakeSync: before this change each one takes 80+ seconds to execute.
> - ConnectTimeoutNoProxyAsync, ConnectTimeoutNoProxySync, ConnectTimeoutWithProxyAsync, ConnectTimeoutWithProxySync: before this change each one takes 50+ seconds to execute.
> 
> After this change each test completes successfully under 10 seconds.

The change looks reasonable to me. All these tests have been added via [JDK-8208391](https://bugs.openjdk.org/browse/JDK-8208391) enhancement, and it seems that the removed timeout cases doesn't hold any specific meaning, therefore looks good to remove them.

-------------

Marked as reviewed by aefimov (Committer).

PR: https://git.openjdk.org/jdk/pull/10605


More information about the net-dev mailing list