RFR: 8288493: Document JDK specific system properties in jdk.httpserver [v7]

Jaikiran Pai jpai at openjdk.org
Thu Oct 20 15:06:50 UTC 2022


On Thu, 20 Oct 2022 15:02:18 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   after review
>
> src/jdk.httpserver/share/classes/module-info.java line 58:
> 
>> 56:  * The maximum number of idle connections at a time.
>> 57:  * </li>
>> 58:  * <li><p><b>{@systemProperty sun.net.httpserver.drainAmount}</b> (default: 64K)<br>
> 
> Hello Michael, sorry I missed this in my previous review. The value for `drainAmount` is expected to be a `long` value. So I think the default value here should be `65536`. Readers might take the `64K` value literally and might attempt to pass similar values to this property which will then lead to failures.

Do we additionally have to specify the behaviour when the value is `<=0`?

-------------

PR: https://git.openjdk.org/jdk/pull/10766


More information about the net-dev mailing list