RFR: 8288493: Document JDK specific system properties in jdk.httpserver [v7]

Michael McMahon michaelm at openjdk.org
Thu Oct 20 15:22:51 UTC 2022


On Thu, 20 Oct 2022 15:03:11 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> src/jdk.httpserver/share/classes/module-info.java line 58:
>> 
>>> 56:  * The maximum number of idle connections at a time.
>>> 57:  * </li>
>>> 58:  * <li><p><b>{@systemProperty sun.net.httpserver.drainAmount}</b> (default: 64K)<br>
>> 
>> Hello Michael, sorry I missed this in my previous review. The value for `drainAmount` is expected to be a `long` value. So I think the default value here should be `65536`. Readers might take the `64K` value literally and might attempt to pass similar values to this property which will then lead to failures.
>
> Do we additionally have to specify the behaviour when the value is `<=0`?

Okay, I can change the `64K` to `65536`. I think the spec already covers the `<=0` case. Thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/10766


More information about the net-dev mailing list