RFR: 8051627: Invariants about java.net.URI resolve and relativize are wrong [v2]

KIRIYAMA Takuya duke at openjdk.org
Fri Sep 16 07:23:58 UTC 2022


On Thu, 11 Aug 2022 14:33:38 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> KIRIYAMA Takuya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - 8051627: Invariants about java.net.URI resolve and relativize are wrong
>>  - Merge branch 'master' into 8051627
>>  - 8051627: Invariants about java.net.URI resolve and relativize are wrong
>>  - 8051627: Invariants about java.net.URI resolve and relativize are wrong
>
> I believe you are correct. Could you update the UriTest with some examples and counter-examples to validate this claim?

@dfuch 
Thank you for your review and suggestions.

> A colon ':' may be more appropriate than a period '.' at the end of this sentence:
> I'd suggest:

You’re right. I changed to use a colon.

> Could you update the UriTest with some examples and counter-examples to validate this claim?

I added tests in URI/Test.java.  
The tests include testing if the resolve-relativize relationship stand when the two URIs meet the condition of the modified javadoc.  
The tests also include testing if the relationship does not stand when the two specific URIs which meets the condition of the original javadoc are given. These URIs are excluded by the condition of the modiied javadoc.

-------------

PR: https://git.openjdk.org/jdk/pull/9671


More information about the net-dev mailing list