RFR: 8051627: Invariants about java.net.URI resolve and relativize are wrong [v2]

Daniel Fuchs dfuchs at openjdk.org
Wed Sep 28 11:15:26 UTC 2022


On Fri, 16 Sep 2022 07:20:11 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

>> I believe you are correct. Could you update the UriTest with some examples and counter-examples to validate this claim?
>
> @dfuch 
> Thank you for your review and suggestions.
> 
>> A colon ':' may be more appropriate than a period '.' at the end of this sentence:
>> I'd suggest:
> 
> You’re right. I changed to use a colon.
> 
>> Could you update the UriTest with some examples and counter-examples to validate this claim?
> 
> I added tests in URI/Test.java.  
> The tests include testing if the resolve-relativize relationship stand when the two URIs meet the condition of the modified javadoc.  
> The tests also include testing if the relationship does not stand when the two specific URIs which meets the condition of the original javadoc are given. These URIs are excluded by the condition of the modiied javadoc.

Hi @tkiriyama sorry for taking so long to get back to you. I had a look at the CSR - and fixed a few missing fields, and added myself as reviewer. Please move its state to "Proposed" to get this moving further.

-------------

PR: https://git.openjdk.org/jdk/pull/9671


More information about the net-dev mailing list