RFR: 8288109: HttpExchangeImpl.setAttribute does not allow null value after JDK-8266897 [v2]

Daniel Jeliński djelinski at openjdk.org
Mon Apr 3 14:32:01 UTC 2023


On Mon, 3 Apr 2023 05:05:09 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use URIBuilder
>
> test/jdk/com/sun/net/httpserver/ExchangeAttributeTest.java line 29:
> 
>> 27:  * @summary Tests for HttpExchange set/getAttribute
>> 28:  * @library /test/lib
>> 29:  * @run junit/othervm ExchangeAttributeTest
> 
> Hello Daniel, I didn't see anything specific in the test which would need `othervm`. Is it the use of `ConsoleHandler` against the `com.sun.net.httpserver` logger which prompted the use of `othervm`?

Actually, I wanted to make sure the HttpClient will be closed as soon as possible. And yes, the logger would also leak to other tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13264#discussion_r1156046156


More information about the net-dev mailing list