RFR: 8288109: HttpExchangeImpl.setAttribute does not allow null value after JDK-8266897 [v2]
Jaikiran Pai
jpai at openjdk.org
Mon Apr 3 14:41:59 UTC 2023
On Mon, 3 Apr 2023 14:29:29 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> test/jdk/com/sun/net/httpserver/ExchangeAttributeTest.java line 29:
>>
>>> 27: * @summary Tests for HttpExchange set/getAttribute
>>> 28: * @library /test/lib
>>> 29: * @run junit/othervm ExchangeAttributeTest
>>
>> Hello Daniel, I didn't see anything specific in the test which would need `othervm`. Is it the use of `ConsoleHandler` against the `com.sun.net.httpserver` logger which prompted the use of `othervm`?
>
> Actually, I wanted to make sure the HttpClient will be closed as soon as possible. And yes, the logger would also leak to other tests.
Sounds fine to me then.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13264#discussion_r1156058981
More information about the net-dev
mailing list