RFR: 8293786: HttpClient will not send more than 64 kb of data from the 2nd request in http2 [v2]
Daniel Fuchs
dfuchs at openjdk.org
Fri Apr 7 14:06:44 UTC 2023
On Fri, 7 Apr 2023 13:41:23 GMT, Conor Cleary <ccleary at openjdk.org> wrote:
>> This is strange and probably too late: when you reach here the bos has probably already been closed by the handler, so setting the flag will have no effect in the usual case.
>
> In the usual case yes, if the handler reads the stream this code will have no effect. I think thats what we want though as we don't want the sending of reset frame to be triggered if the server handler reads/closes the stream. It should only be sent when the stream has not been closed/consumed by the handler and the exchanges send window has been exceeded.
I see. That sounds right. Can you had a comment above line 736 to explain that?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12694#discussion_r1160724171
More information about the net-dev
mailing list