RFR: 8293786: HttpClient will not send more than 64 kb of data from the 2nd request in http2 [v2]
Conor Cleary
ccleary at openjdk.org
Tue Apr 11 08:26:36 UTC 2023
On Fri, 7 Apr 2023 14:03:30 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> In the usual case yes, if the handler reads the stream this code will have no effect. I think thats what we want though as we don't want the sending of reset frame to be triggered if the server handler reads/closes the stream. It should only be sent when the stream has not been closed/consumed by the handler and the exchanges send window has been exceeded.
>
> I see. That sounds right. Can you had a comment above line 736 to explain that?
Was thinking of putting the comment:
// If the handler reads the exchange's InputStream, this code will have no effect. If the handler does not
// read the exchange's InputStream and the send window has been exceeded, then the stream will be reset.
Sort of a simplified version of my previous PR comment to you
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12694#discussion_r1162466556
More information about the net-dev
mailing list