RFR: 8304818: Prune HttpURLConnection cache when corresponding Authenticator is garbage collected [v8]
Jaikiran Pai
jpai at openjdk.org
Wed Apr 12 10:15:34 UTC 2023
On Wed, 12 Apr 2023 07:53:28 GMT, Michael McMahon <michaelm at openjdk.org> wrote:
>> Hi,
>>
>> Can I get a review for this please? This change uses a Cleaner to check when java.net.Authenticator instances become unreachable, and then prunes the authentication cache for entries that correspond to that Authenticator and therefore cannot be used again. This stops the authentication cache from growing in size unbounded. Note, this only happens in the probably unusual case where more than one Authenticator object is used. Normally there is no reason to use more than one instance.
>>
>> Thanks,
>> Michael.
>
> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>
> update to remove dependency on AuthCacheImpl in j.n.Authenticator
test/jdk/java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java line 75:
> 73: * @run main/othervm HTTPSetAuthenticatorTest BASIC SERVER307
> 74: * @run main/othervm HTTPSetAuthenticatorTest BASICSERVER SERVER
> 75: * @run main/othervm HTTPSetAuthenticatorTest BASICSERVER SERVER307
Is it intentional to remove many of these `@run` actions on this test?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13159#discussion_r1163924648
More information about the net-dev
mailing list