RFR: 8304818: Prune HttpURLConnection cache when corresponding Authenticator is garbage collected [v8]

[Michael McMahon]

On Wed, 12 Apr 2023 10:09:10 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update to remove dependency on AuthCacheImpl in j.n.Authenticator
>
> src/java.base/share/classes/sun/net/www/protocol/http/NTLMAuthenticationProxy.java line 77:
> 
>> 75:                               AuthCacheImpl authcache) {
>> 76:         try {
>> 77:             return sixArgCtr.newInstance(isProxy, host, port, pw, authcache);
> 
> Not because of the changes in this PR, but this field is oddly named. It says six arg constructor but infact is a five arg constructor.

Good catch!

> test/jdk/java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java line 75:
> 
>> 73:  * @run main/othervm HTTPSetAuthenticatorTest BASIC  SERVER307
>> 74:  * @run main/othervm HTTPSetAuthenticatorTest BASICSERVER SERVER
>> 75:  * @run main/othervm HTTPSetAuthenticatorTest BASICSERVER SERVER307
> 
> Is it intentional to remove many of these `@run` actions on this test?

No, I only just noticed that also ..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13159#discussion_r1163968989
PR Review Comment: https://git.openjdk.org/jdk/pull/13159#discussion_r1163969694